Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: backport retro compatible commits for the Docusaurus v2.4.2 release #9324

Merged
merged 6 commits into from
Sep 20, 2023
Merged

chore: backport retro compatible commits for the Docusaurus v2.4.2 release #9324

merged 6 commits into from
Sep 20, 2023

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Sep 20, 2023 •
edited
Loading

Motivation

chore: backport retro compatible commits for the Docusaurus v2.4.2 release

Deploy preview: https://deploy-preview-9324--docusaurus-2.netlify.app/

All v2.4.2 links:

@slorber slorber added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label Sep 20, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 20, 2023
ori-shalom and others added 4 commits September 20, 2023 16:51
@ori-shalom @Josh-Cena @slorber
fix(theme): canonical url should be not change after hydration if url…
e531891 
… accessed with/without trailing slash (#9130)

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Co-authored-by: sebastienlorber <lorber.sebastien@gmail.com>
@homotechsual @slorber
fix(theme): only set classname on ul elements if they have an existin…
471330d 
…g class (#9099)

Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>
Co-authored-by: sebastienlorber <lorber.sebastien@gmail.com>
@TheCatLady @slorber
feat(theme-classic): add description & keywords microdata to blog pos…
2bf528a 
…ts (#9108)
@TheCatLady @slorber
fix(content-docs): sidebar generator should return customProps for do…
0236d91 
…c items (#9107)
@netlify
Copy link

netlify bot commented Sep 20, 2023

✅ [V2]

Name Link
🔨 Latest commit d1d9c00
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/650b06db6e3b48000819dea3
😎 Deploy Preview https://deploy-preview-9324--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 84 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 79 🟢 100 🟢 100 🟢 100 🟢 90 Report

@netlify
Copy link

netlify bot commented Sep 20, 2023

✅ [V2]

Name Link
🔨 Latest commit 0236d91
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/650b0812f46e470008a03f53
😎 Deploy Preview https://deploy-preview-9324--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@slorber slorber mentioned this pull request Sep 20, 2023
Merged
@github-actions
Copy link

Size Change: +410 B (0%)

Total Size: 818 kB

Filename Size Change
website/build/assets/css/styles.********.css 107 kB +52 B (0%)
website/build/assets/js/main.********.js 619 kB +332 B (0%)
ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 53.8 kB 0 B
website/build/index.html 39.3 kB +26 B (0%)

compressed-size-action

@slorber slorber merged commit 4ab5a93 into docusaurus-v2 Sep 20, 2023
28 checks passed
@slorber slorber deleted the slorber/docusaurus-v2.4.2-backport branch September 20, 2023 15:29
This was referenced Sep 20, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lex111 lex111 Awaiting requested review from lex111

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@slorber @facebook-github-bot @ori-shalom @homotechsual @TheCatLady