This repository has been archived by the owner on Feb 1, 2020. It is now read-only.
Fix read/write commands to fp regs #290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjricci
force-pushed
the
stmm_regs
branch
5 times, most recently
from
eb5d65b
to
0705f14
Compare
fjricci
changed the title
fjricci
force-pushed
the
stmm_regs
branch
2 times, most recently
from
e2e0932
to
1f7507e
Compare
| @@ -103,9 +103,9 @@ struct CPUState64 { | |||
| SSEVector _sse[128]; | |||
| }; | |||
| SSEVector const &operator[](size_t index) const { | |||
| return _sse[index << 1]; | |||
| return _sse[index << 2]; | |||
There was a problem hiding this comment.
This fix is valid regardless of the previous two commits, right?
fjricci
force-pushed
the
stmm_regs
branch
2 times, most recently
from
2c21798
to
fee853f
Compare
| state.x87.foseg = xfpregs.fpregs.fos; | ||
| state.x87.fooff = xfpregs.fpregs.foo; | ||
|
|
||
| uint8_t const *st_space = |
fjricci
force-pushed
the
stmm_regs
branch
2 times, most recently
from
13a819c
to
ffdb60f
Compare
fjricci
force-pushed
the
stmm_regs
branch
2 times, most recently
from
0868f85
to
063c714
Compare
| static inline void user_to_state32(ds2::Architecture::X86_64::CPUState32 &state, | ||
| user_fpregs_struct const &user) { | ||
| static inline void | ||
| xfpregs_to_state32(ds2::Architecture::X86_64::CPUState32 &state, |
There was a problem hiding this comment.
You can keep the old name, user_to_state32. I think we just use "user" everywhere to describe the structure that comes from the thread's context.
fjricci
force-pushed
the
stmm_regs
branch
3 times, most recently
from
c553129
to
c9c6bae
Compare
|
@sas will do the refactors in a non-gross way 😆 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.