Add Numeral dimension for new language KM. #234
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
chinmay87 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@pheaktra21 - Thank you for the awesome contribution! The files you added didn't build in this commit since they were not added to duckling.cabal. Can you please add them and check that all the test cases pass. I added them at my end (and few more changes to pipe in the new language) but saw that the first test case is failing. Again, thanks for working on this!! Would be great to have Khmer in Duckling |
|
@pheaktra21 has updated the pull request. Re-import the pull request |
|
@chinmay87 - Thank you for spending time looking into it. I have modified some files to have the new language added, and minimized the corpus and rules so that it could pass the test (I am having hard time working with Hashell). I will add more data and rules later. Please check if everything is fine. |
There was a problem hiding this comment.
chinmay87 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Great work @pheaktra21 !! |
Hello,
I am new to Haskell, but I would like to add Khmer language (KM) to Duckling.
I have tried to extended Duckling by adding Numeral dimension for new language KM.
Please have a look at it and see what we can improve.
Thanks!