-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minor issues in german. #362
Conversation
developing right with docker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haoxuany has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Hi @josuablejeru, Thanks for the submission! I'll help with landing the german changes. Could you submit a separate pull request for the docker image changes, instead of putting it in a single pull request? Thank you! |
Hi @josuablejeru, Thanks for the contribution, I've landed your changes related to German! 😄 Cheers. |
This Pullrequest includes.
That is done
README.md
is up to date with dockerdocker-compose.yml
is includedapt-get
commands are in a single RUN command to avoid multiple stages