Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependencies #2254

Closed
wants to merge 2 commits into from
Closed

Conversation

giginet
Copy link
Contributor

@giginet giginet commented Aug 30, 2023

Thanks for proposing a pull request!

To help us review the request, please complete the following:

  • sign contributor license agreement
  • I've ensured that all existing tests pass and added tests (when/where necessary)
  • I've updated the documentation (when/where necessary) and Changelog (when/where necessary)
  • I've added the proper label to this pull request (e.g. bug for bug fixes)

Pull Request Details

I found the required dependencies are missing in the Package.swift.

These are the related targets.

  • FacebookAEM( .aem)
  • FBAEMKit (.Prefixed.aem)
  • FBSDKCoreKit_Basics (.Prefixed.basics)

FacebookAEM requires FBAEM. FacebookAEM just exports FBAEM interfaces.

@_exported import FBAEMKit

FBAEMKit imports FBSDKCoreKit_Basics. In fact, .swiftinterface of distributed FBAEMKit.xcframework attempts to import FBSDKCoreKit_Basics.

So it need to add dependencies for FBSDKCoreKit_Basics. But there are no dependencies.
It causes error on some build environment.

FBAEMKit is a binary target, so it can't have dependencies directly. So I added the dependencies to FBSDKCoreKit_Basics from FacebookAEM.

Test Plan

This manifest works.

@giginet giginet requested a review from joesus as a code owner August 30, 2023 06:40
@facebook-github-bot
Copy link
Contributor

Hi @giginet!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@giginet
Copy link
Contributor Author

giginet commented Aug 30, 2023

CLA Signed

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@giginet
Copy link
Contributor Author

giginet commented Sep 14, 2023

Hi. Do you have any updates?

@giginet
Copy link
Contributor Author

giginet commented Sep 25, 2023

@joesus Hi. Could you check this PR?

@facebook-github-bot
Copy link
Contributor

@TimOliver has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@TimOliver merged this pull request in 3ca0553.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants