Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for proposing a pull request!
To help us review the request, please complete the following:
bug
for bug fixes)Pull Request Details
I found the required dependencies are missing in the Package.swift.
These are the related targets.
.aem
).Prefixed.aem
).Prefixed.basics
)FacebookAEM requires FBAEM. FacebookAEM just exports FBAEM interfaces.
facebook-ios-sdk/Sources/FacebookAEM/Exports.swift
Line 10 in 41044df
FBAEMKit
importsFBSDKCoreKit_Basics
. In fact,.swiftinterface
of distributedFBAEMKit.xcframework
attempts to importFBSDKCoreKit_Basics
.So it need to add dependencies for
FBSDKCoreKit_Basics
. But there are no dependencies.It causes error on some build environment.
FBAEMKit
is a binary target, so it can't have dependencies directly. So I added the dependencies toFBSDKCoreKit_Basics
fromFacebookAEM
.Test Plan
This manifest works.