-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Babel preset & cleanup #135
Conversation
This makes it so we can move all possible babel plugins into the preset and not have to special case the flow target in the gulpfile with manual plugins configuration. This will be useful for other projects as well and should be identical.
Ok, rebased everything from the beginning so we shouldn't be introducing any unnecessary deps and un-rearranged the package.jsons for easier diffing (I know, npm did it but it was excruciating to rebase so hopefully I didn't screw that up). Last but not least, here's the diff of |
Alright, calling this done. Will merge & ship cc @kassens |
Is pulling out Now that babel 6 is compiled with babel 6, the babel family of packages is using |
Are you talking about |
I'm talking about
I know React doesn't need |
oooohhh I see. I was confused because that's distinct from this PR :) That should never have been a dependency, I missed it in #121. It's definitely unused and we can publish fbjs@0.8.2 to fix. |
Summary: `fbjs` was updated to not include `babel-plugin-syntax-flow`, this reduces our production builds by ~7.5mb. Thanks zpao! See facebook/fbjs#135 (comment). Reviewed By: ssorallen Differential Revision: D3267846 fb-gh-sync-id: eebb23dd05ca72168a3c7beb717f10d3779a864e fbshipit-source-id: eebb23dd05ca72168a3c7beb717f10d3779a864e
This revives #127. @yungsters is out for a little while so not going to put this on him.
.js.flow
files can also be generated with the preset so project doesn't have to declare any plugins explicitlyScroll
is failing)fbjs-scripts
(will likely just ship 0.7 after this is done with this being the only change).