Split packages #159
Merged
Split packages #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help keep these packages distinct and help split them further, eventually using something like Lerna to automate releases.
No real code changes so each of these published packages should be virtually identical.
ghost
added
the
Closed
|
Nice. It begins! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't use Lerna (yet[*]) but ultimately the goal here is to set clearer boundaries between these packages. It should also make it easier to further split up the packages and bring in more maintainers.
cc @yungsters - this is what I was talking about doing. It doesn't affect our other syncing plans much (I think).
[*]: This is because we currently do things like
require('fbjs-scripts/gulp/foo'). Lerna makes package-level requires work but not deep ones.