weutil : Changes to support Meru800bia #156
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use FIELD_UINT instead of FIELD_HEX to parse CRC16 to be consistent with V4 spec:
parseHex()
function is currently used to parse FIELD_HEX values.parseHex()
function internally usesstd::stoi()
to convert the bytes to a hex value. Since the CRC16 bytes are uint values (and not their ASCII equivalent)parseHex()
function won’t work. Changing to FIELD_UINT would make sure the right parsing functionparseUint()
is used.Introduce a new local variable
lastByte
inloadEeprom()
function to handle large offset values:This helps to avoid limiting
fileSize
to a maximum value equal to the buffer size in the linefileSize = fileSize > max ? max : fileSize;
. As a result, the offset value can be larger than the buffer size. Previously, the following check caused exceptions whenever the offset exceeded the buffer sizeAdditionally,
lastByte
also helps to track the number of bytes to be read whenoffset
value is larger than the buffer sizeStore lowercase string in translatedFrom:
In the
getEepromPath()
function, settranslatedFrom
to the lowercase stringlEeprom
.translatedFrom
is later used to look upconfig_.configEntry
which stores keys in lowercase.Testing
Read EEPROM with the command
weutil --eeprom SCM --config_file weutil.json