You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
<fbt desc="...">
<fbt:param name="name" gender={this.state.ex1Gender}>
<b className="padRight">{this.state.ex1Name}</b>
</fbt:param>
has shared
<a className="neatoLink" href="#">
<fbt:plural
many="photos"
showCount="ifMany"
count={this.state.ex1Count}>
a photo
</fbt:plural>
</a>
with you
</fbt>
Extracts to
{
"hashToText": {
"PqPPir8Kg9xSlqdednPFOg==": "{name} has shared {=a photo} with you"
},
"jsfbt": {
"t": {
"*": "{name} has shared {=a photo} with you"
},
"m": [
{
"token": "name",
"type": 1
}
]
}
},
{
"hashToText": {
"/gj3gwqx1z8Xw233oZgOpQ==": "{number} photos",
"8UZCD6gFUKN+U5UUo1I3/w==": " a photo"
},
"desc": "In the phrase: \"{=} has shared {=a photo} with you\"",
"jsfbt": {
"t": {
"*": "{number} photos",
"_1": " a photo"
},
"m": [
{
"token": "number",
"type": 2,
"singular": true
}
]
}
}
Notice both the "{=}" token and the {=a photo} token in the description:
'In the phrase: "{=} has shared {= a photo} with you"'
So two things wrong here. {=} should be {name} AND the {number} photos variant of the <fbt:plural> instance needs its own description such that its token corresponds to the inner text:
'In the phrase: "{name} has shared {=[number] photos} with you"'
There should be two separate outer strings here (not one):
"{name} has shared {=a photo} with you"
"{name} has shared {=[number] photos} with you"
and inner-strings should have separate descriptions:
'In the phrase: "{name} has shared {=a photo} with you"'
'In the phrase: "{name} has shared {=[number] photos} with you"'
The text was updated successfully, but these errors were encountered:
jrwats
changed the title
Auto-wrapping is broken for fbt:* children
Auto-wrapping is broken for non-textual children (fbt:*, template literals, etc)
Jan 30, 2019
This is fully evident even in the example app:
Extracts to
Notice both the
"{=}"
token and the{=a photo}
token in the description:So two things wrong here.
{=}
should be{name}
AND the{number} photos
variant of the<fbt:plural>
instance needs its own description such that its token corresponds to the inner text:There should be two separate outer strings here (not one):
and inner-strings should have separate descriptions:
The text was updated successfully, but these errors were encountered: