-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
android: upgrade rn-demo-app to RN 0.64.0 #234
Conversation
cc @hramos |
@jrwats has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
@ecreeth has updated the pull request. You must reimport the pull request before landing. |
I just update the |
@ecreeth has updated the pull request. You must reimport the pull request before landing. |
@kayhadrin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
@ecreeth has updated the pull request. You must reimport the pull request before landing. |
1 similar comment
@ecreeth has updated the pull request. You must reimport the pull request before landing. |
@jrwats is done! |
@kayhadrin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
@kayhadrin What's failing? Can I solve the problem or is it an internal-related issue? |
More easily maintain RN updates by using react-native-test-app Here is a video of how it works in Microsoft https://www.youtube.com/watch?v=DAEnPV78rQc |
Sorry it's been a while since this PR was submitted and it's getting rebase conflicts. |
Summary
In 8fdbce6 the dependencies were updated to
0.64.0
but not in the Android native side.android
code to0.64.0
react-native-fbt
to0.0.5
added temporal fix toreact-native-fbt
. In version0.0.3
this package has a mistake; its calling a file that doesn't exists in that location. Thejs
directory is not foundfbt/packages/react-native-fbt/package.json
Line 6 in 73468ad
Now the application build successfully
The
react-native-fbt
package needs to be updated to0.0.3
. In new versions of React Native theTurboModuleRegistry
is found in another destination, so the application will not compile.fbt/packages/react-native-fbt/index.js
Line 22 in 893492c
This is resolved in
0.0.3
fbt/packages/react-native-fbt/NativeFbtModule.js
Line 27 in 893492c
Test plan