Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update databases-plugin.md #564

Closed
wants to merge 1 commit into from

Conversation

mateosilguero
Copy link
Contributor

Summary

Changelog

Test Plan

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@passy
Copy link
Member

passy commented Sep 30, 2019

Thanks for catching this! @mateosilguero could you sign the CLA please so I can merge this?

@passy
Copy link
Member

passy commented Oct 1, 2019

@mateosilguero Apologies but I'm not quite sure how to understand that reaction on the message. :) Unfortunately, I can't merge this unless you sign that waiver.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 1, 2019
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@mateosilguero
Copy link
Contributor Author

Sorry, i just signed the cla.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@passy is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@passy
Copy link
Member

passy commented Oct 2, 2019

Brilliant. Thanks a lot for the fixes. Please keep them coming. :)

@facebook-github-bot
Copy link
Contributor

@passy merged this pull request in 4c3028b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants