Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated Flow types for object keys with / or - missing quotes #6368

Closed
sandersky opened this issue May 27, 2018 · 1 comment
Closed

Generated Flow types for object keys with / or - missing quotes #6368

sandersky opened this issue May 27, 2018 · 1 comment

Comments

@sandersky
Copy link

I'm using flow gen-flow-files for the following source code:

/**
 * @flow
 */

import {rule as reactComponentFlowTypeNames} from './rules/react-component-flow-type-names'

export default {
  configs: {
    recommended: {
      rules: {
        'opinionated/react-component-flow-type-names': 2,
      },
    },
  },
  rules: {
    'react-component-flow-type-names': reactComponentFlowTypeNames,
  },
}

and the generate Flow types file isn't properly adding quotes around object keys containing / or - in them. See this pull request for an example of where this is occurring and how I'm getting around it with a script that does basic find/replace to fix the occurrences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants