Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile error under libc++ #72

Closed
likan999 opened this issue Jul 5, 2014 · 1 comment
Closed

Compile error under libc++ #72

likan999 opened this issue Jul 5, 2014 · 1 comment

Comments

@likan999
Copy link

likan999 commented Jul 5, 2014

In file included from Bits.cpp:17:
In file included from ./../folly/Bits.h:58:
In file included from ./../folly/Portability.h:191:
./../folly/detail/FunctionalExcept.h:22:1: error: unknown type name '_LIBCPP_BEGIN_NAMESPACE_STD'
FOLLY_NAMESPACE_STD_BEGIN

Obviously _LIBCPP_BEGIN_NAMESPACE_STD is not recognized. One needs to include any standard header to get the definition of _LIBCPP_BEGIN_NAMESPACE_STD. Or include <__config>.
@tudor
Copy link
Contributor

tudor commented Jul 5, 2014

Thanks for the report. Fixed in our internal repo, I'll push a fixed version on Monday.

tudor added a commit that referenced this issue Jul 9, 2014
@tudor
Fix libc++ build errors
eaed555 
Summary:
Reported externally:

#70
#71
#72
#73

Note that I can't test on libc++ myself, but the reports suggested fixes which
sounded good.

Test Plan: fbconfig -r folly && fbmake runtests_opt

Reviewed By: marcelo.juchem@fb.com

Subscribers: jhj, ntv, lesha, kma, fugalh, jdelong

FB internal diff: D1421029
@tudor tudor closed this as completed Jul 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tudor @likan999