Attributes translation #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__attribute__ is very compiler specific, this supports forcing inline and forcing noinline for gcc and msvc - clang will try to act like gcc on nix systems and msc on windows
unfortunately the pragma push/pop syntax is ugly which makes the macros a little more obnoxious
this will make everything fallback to c++11 alignas and alignof if they're detected to be working, but will use platform specific alignas/alignof/max align if not
the only remaining __attribute__ uses are ifdef'd off by sanitizer, ifunc, and weak ref checks
since it's not using portability, have to do the same thing here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns gcc attribute functionality into macros that can be used
it also allows for easy fallback if the cmake system detects alignas/alignof support, provides maxalign and specific align macros, takes care of inline and noline
packing structs is rather ugly, but this seems to be the least ugly of the hacky workarounds for the differences in implementationation