a proposal for correcting 4797 #6844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Add snapshot support for APC priming, to load faster and with less memory than current shared library format. The new format is auto-detected when passed to the existing PrimeLibrary flag (it can even keep the .so extension). To "upgrade" an existing .so to the new format, there is a new flag that just writes the snapshot to a file and then exits hhvm (without starting any servers). Reviewed By: binliu19 Differential Revision: D2826183 fb-gh-sync-id: 5f49d96
Reviewed By: emiraga Differential Revision: D2845107 fb-gh-sync-id: 9364b82
Summary: The implemention of in() in hhbbc/interp.cpp for the CGetNQuiet bytecode should be identical to that of CGetN. The intention was that we could re-use the same implemention by just calling the CGetN implementation. Since the CGetN implementation did not actually refer to anything in the opcode, we could obtain the proper overloading behavior by just casting a null to a CGetN. Unfortunately, a typo meant that we casted to CGetNQuiet instead, meaning we just recursively call ourself infinitely. Rather than just fix the typo, avoid the hackery of casting a nullptr by factoring out the CGetN implementation into a separate function and having both CGetN and CGetNQuiet call that. It also turns out that the implementations shouldn't be quite identical, they need a template parameter to determine which CGetL equivalent they should be optimized to. Also add a test case to actually exercise these different "quiet" versions of CGet. Reviewed By: markw65 Differential Revision: D2850127 fb-gh-sync-id: bf9142e
Summary: If anything threw while it was loading the unit, the unit would be forever marked as not existing. Originally, nothing should have thrown, but we added surprise checks to the unserialize code, so timeouts, and ooms could end up throwing. This only affects RepoAuthoritative mode; in sandbox mode, we'll just try again if we find an entry with a null unit. Reviewed By: swtaarrs Differential Revision: D2867957 fb-gh-sync-id: 8eddfa5
Summary: When hhvm was built in fbsource, we would get a version string looking like "gfbcode: <sha1>" rather than "g<sha1>". This broke various tools, and at least one flib test. Reviewed By: mxw Differential Revision: D2866405 fb-gh-sync-id: e66ec77
|
This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D54441 |
|
There are too many commits associated with this pull request and you are trying to patch stuff from a release branch into I am going to close this, and you can try again if you want. Normally you would fork your repo from |
|
Ok, thanks Joel ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This one is for correcting issue #4797.
That's my first pull request, let's see if I 'll survive...
Well, dont think so ...."archibaldhaddock wants to merge 7 commits into master from HHVM-3.12"
Never in my life !
Well, I'll see tomorow if I can do something wih my git diff and test file...