Managed & Unmanaged FBSimulator #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
lawrencelomax
added a commit
that referenced
this pull request
Sep 23, 2015
Managed & Unmanaged FBSimulator
This was referenced Sep 23, 2015
plu
added a commit
to plu/FBSimulatorControl
that referenced
this pull request
Feb 26, 2017
plu
added a commit
to plu/FBSimulatorControl
that referenced
this pull request
Feb 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts out
FBSimulatorsimulator behavior to allow all Simulators to be wrapped with theFBSimulatorconveniences that are relevant, regardless of whether they are managed or unmanaged.A Concreted subclass
FBManagedSimulatordeals with allocation/freeing of these Simulators. This improves a lot of the inflation ofSimDevicetoFBSimulatorand means thatFBSimulatorPoolspends a lot less time dealing with heterogeneous objects.This also means that expensive information about a simulator (for example the construction of processes that have been created through
launchd_sim) can be done lazily and will apply to any simulator, not just 'managed' ones.