Populate glInternalFormat when creating OpenGL texture as externally managed #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…managed Summary: If creating `TextureBuffer` via `createTextureBufferExternal`, the `glInternalFormat_` wasn't correctly populated (remaining at 0), violating the internal consistency of the corresponding Texture object. When tried to be used later by a client with OpenGL ES backend, this would assert in `getGLInternalTextureFormat` because of that. This diff correspondingly makes sure that if we use ` createTextureBufferExternal` then `glInternalFormat_` is set to whatever value corresponds to that externally managed texture. Differential Revision: D61905498
|
This pull request was exported from Phabricator. Differential Revision: D61905498 |
|
This pull request has been merged in fa1618b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
If creating
TextureBufferviacreateTextureBufferExternal, theglInternalFormat_wasn't correctly populated (remaining at 0), violating the internal consistency of the corresponding Texture object.When tried to be used later by a client with OpenGL ES backend, this would assert in
getGLInternalTextureFormatbecause of that.This diff correspondingly makes sure that if we use
createTextureBufferExternalthenglInternalFormat_is set to whatever value corresponds to that externally managed texture.Differential Revision: D61905498