ArrayBuffer regression in node env

[sirian]

🐛 Bug Report

#7626 introduced regression

expect(new Uint8Array([]).buffer).toBeInstanceOf(ArrayBuffer);

fails with

    Expected constructor: ArrayBuffer
    Received constructor: ArrayBuffer
    Received value: []

[SimenB]

@H1Gdev ideas?

[SimenB]

This might be #2549

[H1Gdev]

@SimenB

Oh...:cry:

Seems that there are multiple type of ArrayBuffer in Node.js vm.

There is also a way to add TypedArrays like ArrayBuffer is easy workaround.
https://developer.mozilla.org/ja/docs/Web/JavaScript/Reference/Global_Objects/TypedArray

[H1Gdev]

@SimenB

Execute the following code in each environment.(--env=node, --env=jsdom, and node).

const bufFromArray = Buffer.from([0x62, 0x75, 0x66, 0x66, 0x65, 0x72]);
bufFromArray instanceof Uint8Array;
const bufFromArrayBuffer = Buffer.from(new ArrayBuffer(6));
bufFromArrayBuffer instanceof Uint8Array;

In --env=node, results are not true.

It seems that Uint8Array also has the same issue as ArrayBuffer.

[sirian]

@SimenB

Oh...😢

Seems that there are multiple type of ArrayBuffer in Node.js vm.

There is also a way to add TypedArrays like ArrayBuffer is easy workaround.
https://developer.mozilla.org/ja/docs/Web/JavaScript/Reference/Global_Objects/TypedArray

not only ArrayBuffer. all globals in vm context differs from globals of main process.
But new vm context doesn't have Buffer. So in this line vmGlobal.Buffer = mainGlobal.Buffer explicitly assigned https://github.com/facebook/jest/blob/master/packages/jest-util/src/installCommonGlobals.js#L65

so both contexts (main and vm) has same Buffer from main context. And Buffer.from() called in vmContext returns instance of mainGlobal.ArrayBuffer.

Probably it's better to contextify Buffer constructor, Buffer.prototype and static methods in installCommonGlobals. Like in vm2 https://github.com/patriksimek/vm2

[sirian]

Moreover since Buffer from different context this both fails:

expect(Buffer instanceof Object).toBe(true);
expect(Buffer instanceof Function).toBe(true);

Upd. Full test case of globals if needed:

const data = [];
for (const key in global) {
    const value = global[key];
    if ("function" === typeof value || null !== value && "object" === typeof value) {
        data.push(key);
    }
}

test.each(data)("global[%p] instanceof Object", (key) => {
    expect(global[key]).toBeInstanceOf(Object);
});

[LynxyssCZ]

This is really painful in our project. Caused a lot of false positives and nagatives in tests involving checks for value types.
Instead of simple value instanceof Object before chucking the value into WeakMap as a key I have to do
value instanceof Object || value instanceof Buffer
And explain to colleagues, that this is there just because Jest enviroment demands it to be.

[valamidev]

Possible workaround:

Object.prototype.toString.call( new Uint8Array(10)) === '[object Uint8Array]'

[wi-ski]

This forced me to use mocha.

[wi-ski]

I lied. I came back. Workaround:

// __test-utils__/custom-jest-environment.js
// Stolen from: https://github.com/ipfs/jest-environment-aegir/blob/master/src/index.js
// Overcomes error from jest internals.. this thing: https://github.com/facebook/jest/issues/6248
"use strict";

const NodeEnvironment = require("jest-environment-node");

class MyEnvironment extends NodeEnvironment {
  constructor(config) {
    super(
      Object.assign({}, config, {
        globals: Object.assign({}, config.globals, {
          Uint32Array: Uint32Array,
          Uint8Array: Uint8Array,
          ArrayBuffer: ArrayBuffer,
        }),
      }),
    );
  }

  async setup() {}

  async teardown() {}

}

module.exports = MyEnvironment;

Then in package.json:

  "jest": {
    "testEnvironment": "__test-utils__/custom-jest-environment.js",
    ...
  },

[odahcam]

I just had to put a ./ before the testEnvironment path:

  "jest": {
    "testEnvironment": "./__test-utils__/custom-jest-environment.js",
    ...
  },

[wujekbogdan]

@odahcam @wi-ski

Thanks for sharing the workaround, but it seems to me that the solution is already out of date. I've just installed jest-environment-node@^26.0.1 and in jest.config.js I set:

module.exports = {
  // ...
  testEnvironment: 'node',
};

That's it. I didn't need to extend the NodeEnvironment and overload the constructor. It just worked.

Correct me if I'm wrong, but it seems that when jest-environment-node is installed then jest uses that module to configure the environment. So it looks like the bug is already fixed in jest-environment-node modlue.

Am I right?

[stevenyap]

Setting testEnvironment: 'node' in jest.config.js works for me too without using the workaround. I do not need to install jest-environment-node.

[shrpne]

let t = Buffer.alloc(0)
t instanceof Uint8Array

true in jest-environment-jsdom@25
false in jest-environment-jsdom@26

[arnotixe]

this bug is over a year old - is it an intended side-effect in v26.1.0 or can I open a PR that addresses this

still bit me on jest 26.4.2… but wujekbogdan's solution above adding to jest.config.js did help me!

[mogarick]

I'm running Jest v26.4.0 and the problem occurs even though I added testEnvironment="node" in jest.config.js. I used the code posted by @wi-ski and that solved the problem.
In my case I'm using Amplify and for Auth it uses its own crypto-js module version and it was failing when comparing aVariable instanceof Uint8Array presumably due the the same problem reported here.
Happy to have found this issue and how to cope with it.

[gindyo]

I am still experiencing this issue with jest-environment-jsdom@27. I tried the solution of adding a custom environment, but then the behavior of VSCode's jest extension becomes all wonky. It can't figure out the status of the tests. Ughh

[RobertLowe]

bcrypto broken by this issue https://github.com/bcoin-org/bcrypto/blob/master/lib/native/random-openssl.js#L116

:(

[shrpne]

i worked around this by adding jest-environment-jsdom@25 as a dev dep

jest-environment-jsdom@25 doesn't work with jest@27 anymore

[odbol]

So, create-react-app doesn't allow you to override testEnvironment. Does anyone know a way to apply the workaround when using create-react-app?

I tried using jest { setupGlobals } but that wouldn't let me modify the globals config.

npm test

> my-app@0.1.0 test ***
> react-scripts test


Out of the box, Create React App only supports overriding these Jest options:

  • clearMocks
  • collectCoverageFrom
  • coveragePathIgnorePatterns
  • coverageReporters
  • coverageThreshold
  • displayName
  • extraGlobals
  • globalSetup
  • globalTeardown
  • moduleNameMapper
  • resetMocks
  • resetModules
  • restoreMocks
  • snapshotSerializers
  • testMatch
  • transform
  • transformIgnorePatterns
  • watchPathIgnorePatterns.

These options in your package.json Jest configuration are not currently supported by Create React App:

  • testEnvironment

If you wish to override other Jest options, you need to eject from the default setup. You can do so by running npm run eject but remember that this is a one-way operation. You may also file an issue with Create React App to discuss supporting more options out of the box.

[chrisfosterelli]

@odbol We did this on the command line by replacing the test script in package.json with react-scripts test --env <path-to-file>

[nlinx]

@odbol You can also just add this

/**
 * @jest-environment node
 */

to the top of the file having this issue

[odbol]

Wow, @nlinx, that worked perfectly. Who knew it was so easy? Thanks!

[johnnybenson]

This seems like it is still an issue for Int32Array

/**
 * @jest-environment node
 */

    test('Int32Array Buffer', () => {
        expect(new Int32Array([]).buffer).toBeInstanceOf(ArrayBuffer);
    });

    expect(received).toBeInstanceOf(expected)

    Expected constructor: ArrayBuffer
    Received constructor: ArrayBuffer

      61 |     test('Int32Array Buffer', () => {
    > 62 |         expect(new Int32Array([]).buffer).toBeInstanceOf(ArrayBuffer);
         |                                           ^
      63 |     });

[SimenB]

Example in OP passes in newer versions of Jest. Please open new issues with reproductions for other environments.

(the last example probably still fails due to https://github.com/facebook/jest/blob/b372332a8ff25aca23d36c5297db94581b6d439e/packages/jest-environment-node/src/index.ts#L42, but nevertheless it's a different issue)

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.