-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: Support codemods published to npm #126
Comments
I think it would be great if it was easier to consume codemods. I like both options ✌️ Another option worth considering is custom cli. I did this with my repo of codemods. A benefit with this approach is that jscodeshift becomes a dependency of the codemod and thus the user knows that is it tested with the jscodeshift version they use it with. jscodeshift could have a helper which makes it a bit easier to generate the cli wrapper as well as keeping it in sync with jscodeshift cli options. |
That would be cool. ava-codemods does a similar thing (wraps |
Sorry for the late response, I've been on vacation the last two weeks. I like both ideas.
Definitely. A custom CLI has the advantage that additional preprocessing and configuration could happen before the codemod is run.
Yep, that's what I like too. However, I would expect "non-selfcontained" codemods to list jscodeshift in But being able to run any globally installed codemod could be useful too. I think I like option 1 more. Maybe we could even offer the user to install that module if it doesn't exist (but is available on npm). We could also add a When using a global jscodeshift installation, we could still delegate to the codemod's local jscodeshift version, if available. |
Great :) |
@relekang, yep that would be good. Thanks so much for your help :) |
This was my attempt at this a while back https://github.com/brysgo/jscodemigrate |
I'm in favor of changing jscodeshift's CLI to look for npm packages of transforms automatically, especially since it could theoretically be done without any changes to the existing transforms. As long as they're published on npm, jscodeshift could locate them locally or in the package repository and just provide abstractions for running specific transforms. I think it would also be useful to have an option for running all of a package's transforms together, since many pck have related transforms that are meant to be run together. Perhaps something like That being said, I do think that the custom CLi feature could be very useful, though for what I would want I would find the package-based approach more convenient since I wouldn't have to modify as much existing code or publish new packages. I would be interested in working on this, I just wanted to post my ideas first and see if anyone else has progress or similar ideas. |
I think this should be similar of how react-native or gatsby templates works, something like this:
we should have a default path for the transformer |
Hey folks, I'm working on a project based on jscodeshift that acts as a community registry for codemods. The way it works in a nutshell is:
If you want to publish your codemods you can get started by reading the Authoring and the Contribution guides. The project is called CodeshiftCommunity, if you're interested 😄 It's early days, but would be keen to see what you all think about it/ if you find it useful 😄 |
I made a customized codemod with the following code. #!/usr/bin/env node
import { spawn } from "child_process"
import { readFile } from "fs/promises"
const PACKAGE_NAME = JSON.parse(await readFile(resolve("../package.json"))).name
function resolve(path) {
return import.meta.resolve(path).replace(/^file:\/\/\//, "")
}
function rebrand(data) {
return data.toString().replaceAll("jscodeshift", PACKAGE_NAME)
}
const jscodeshift = spawn(
"node",
[resolve("../node_modules/jscodeshift/bin/jscodeshift.js"), "-t", resolve("../codemod.ts"), ...process.argv.slice(2)],
{ env: { ...process.env, FORCE_COLOR: true } }
)
process.stdin.pipe(jscodeshift.stdin)
jscodeshift.stdout.on("data", data => process.stdout.write(rebrand(data)))
jscodeshift.stderr.on("data", data => process.stderr.write(rebrand(data)))
jscodeshift.on("exit", process.exit) |
Right now, there are 2 ways that a developer can run a codemod:
-t
.js
file (with the caveat that the script must be entirely self contained).I'd like to propose a 3rd option: being able to
npm install -g
a codemod.I can think of 2 different options for how this would work.
-t
or a new flag)jscodeshift
can look for all globally-installed modules matching a specific prefix, and present the developer with a list of available transforms when one is not explicitly provided on the command line (this is how theyo
CLI works foryeoman
).I think the major benefit here would be that it then becomes easier to author + distribute a codemod that is not entirely self-contained. Right now, if I wanted to publish a codemod that uses
require
for modules other than node built-ins, a consumer of my codemod needs to:npm install
Another benefit is discoverability: If the docs encourage users to publish to
npm
with specific tags, it will make searching for available transforms much less of a struggle.This is work I'd definitely be willing to contribute, but wanted to elicit feedback before taking that work on.
The text was updated successfully, but these errors were encountered: