Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected removal of space after a comment #408

Closed
liutikas opened this issue Jul 6, 2023 · 3 comments
Closed

Unexpected removal of space after a comment #408

liutikas opened this issue Jul 6, 2023 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@liutikas
Copy link

liutikas commented Jul 6, 2023

Repro steps

java  -cp /ssd/ssd5/androidx-main/prebuilts/androidx/external/com/facebook/ktfmt/0.44/ktfmt-0.44.jar:..all.jars com.facebook.ktfmt.cli.Main --kotlinlang-style Foo.kt
  • Try to format the following file:
package com.tools.android

class Foo() {
    fun callMe() {
        onDispose { /* do nothing */ }
    }
}

Expected

No changes

Actual

The space after the /* */ comment is removed resulting in

        onDispose { /* do nothing */}

without any space before }

@hick209
Copy link
Contributor

hick209 commented Aug 24, 2023

Just tested this again and the issue is still prevalent

@hick209 hick209 added bug Something isn't working good first issue Good for newcomers labels Sep 15, 2023
fredyw added a commit to fredyw/ktfmt that referenced this issue Oct 5, 2023
fredyw added a commit to fredyw/ktfmt that referenced this issue Oct 5, 2023
@EmmanuelDav
Copy link

hey @hick209 I noticed this issue is still open, is it still available and can I work on it ??

fredyw added a commit to fredyw/ktfmt that referenced this issue Nov 15, 2023
@hick209
Copy link
Contributor

hick209 commented Mar 26, 2024

Sorry the late response @EmmanuelDav, I was out on leave since September (new son).

Looks like @fredyw has already worked on this issue though on #426, but thank you so much for offering 😃

Next time you can feel free to just get started on the issue and submit a PR as we could always start the discussion from there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants