Add Google and Kotlinlang support to IDEA plugin #183
Conversation
facebook-github-bot
added
the
CLA Signed
JavierSegoviaCordoba
changed the title
| import java.util.Map; | ||
|
|
||
| import static com.facebook.ktfmt.FormatterKt.*; |
There was a problem hiding this comment.
Please expand to individual imports.
I know that IntelliJ replaces imports to .* automatically and it's very annoying. To turn off, increase "class count to use import" to a large number.
There was a problem hiding this comment.
I am checking that the order of some imports in multiple files has changed. I was using the Google plugin plus reformat code + optimize imports.
Should I change the order manually?
There was a problem hiding this comment.
Unfortunately the GJF plugin doesn't sort imports (unclear why). In general, to preserve blame and history it's best not to change anything unrelated to your change.
I'll sort them after importing to our internal repo, our linters will complain anyway.
There was a problem hiding this comment.
Spotless does? It has Google format for java.
ktfmt_idea_plugin/src/main/java/com/facebook/ktfmt/intellij/FormatterUtil.java
Outdated
Show resolved
Hide resolved
ktfmt_idea_plugin/src/main/java/com/facebook/ktfmt/intellij/FormatterUtil.java
Outdated
Show resolved
Hide resolved
ktfmt_idea_plugin/src/main/java/com/facebook/ktfmt/intellij/KtfmtConfigurable.java
Outdated
Show resolved
Hide resolved
ktfmt_idea_plugin/src/main/java/com/facebook/ktfmt/intellij/UiFormatterStyle.java
Show resolved
Hide resolved
ktfmt_idea_plugin/src/main/java/com/facebook/ktfmt/intellij/UiFormatterStyle.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@cgrushko has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Now the drop-down has 4 items:
Default, Dropbox, Google and Kotlinlang. Should I delete Dropbox?