Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further tweaks to format/style selection #3895

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Further tweaks to format/style selection #3895

merged 1 commit into from
Feb 13, 2023

Conversation

trueadm
Copy link
Collaborator

@trueadm trueadm commented Feb 13, 2023 •
edited
Loading

Fixes #3891 and #3892.

@vercel
Copy link

vercel bot commented Feb 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 13, 2023 at 10:22AM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 13, 2023 at 10:22AM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 13, 2023
@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 25.97 KB (-0.03% 🔽) 520 ms (-0.03% 🔽) 61 ms (-22.08% 🔽) 580 ms
packages/lexical-rich-text/dist/LexicalRichText.js 36.71 KB (-0.02% 🔽) 735 ms (-0.02% 🔽) 82 ms (-26.57% 🔽) 816 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 36.69 KB (-0.02% 🔽) 734 ms (-0.02% 🔽) 62 ms (-33.79% 🔽) 796 ms

@trueadm trueadm merged commit 3228323 into main Feb 13, 2023
@trueadm trueadm deleted the further-tune-selection branch February 13, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Selection does not maintain style or format when creating a new empty paragraph
3 participants
@trueadm @zurfyx @facebook-github-bot