Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty element deletion #4380

Merged
merged 1 commit into from
May 5, 2023
Merged

Handle empty element deletion #4380

merged 1 commit into from
May 5, 2023

Conversation

fantactuka
Copy link
Contributor

Deleting empty element should not change style of its sibling element:

Before

Screen.Recording.2023-04-21.at.11.46.48.AM.mov

After

Screen.Recording.2023-04-21.at.11.46.28.AM.mov

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 21, 2023
@vercel
Copy link

vercel bot commented Apr 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 7:21pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 7:21pm

@fantactuka fantactuka mentioned this pull request Apr 21, 2023
Merged
@github-actions
Copy link

github-actions bot commented Apr 21, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 27.01 KB (+0.09% 🔺) 541 ms (+0.09% 🔺) 318 ms (+57.99% 🔺) 858 ms
packages/lexical-rich-text/dist/LexicalRichText.js 37.86 KB (+0.05% 🔺) 758 ms (+0.05% 🔺) 218 ms (-53.91% 🔽) 975 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 37.83 KB (+0.05% 🔺) 757 ms (+0.05% 🔺) 288 ms (-3.8% 🔽) 1.1 s

ivailop7
ivailop7 approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@ivailop7 ivailop7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Max! A much needed fix.

@fantactuka fantactuka mentioned this pull request May 1, 2023
Closed
@ivailop7
Copy link
Collaborator

ivailop7 commented May 1, 2023

@zurfyx could we merge this one?

@zurfyx
Copy link
Member

zurfyx commented May 1, 2023

@fantactuka -

[chromium] › packages\lexical-playground_tests_\e2e\Selection.spec.mjs:356:3 › Selection › Can delete sibling elements forward

seems to be consistently failing, can you look into this please?

@fantactuka fantactuka merged commit c321ada into main May 5, 2023
@fantactuka fantactuka deleted the delete-sibling-element branch May 5, 2023 19:45
@yaojiu19
Copy link

when will it be released

This was referenced May 23, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@ivailop7 ivailop7 ivailop7 approved these changes

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fantactuka @ivailop7 @zurfyx @yaojiu19 @facebook-github-bot