Split test files and skip flaky tests in linux + collab #4394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acywatson
requested review from
zurfyx,
fantactuka,
tylerjbainbridge and
thegreatercurve
as code owners
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
zurfyx
approved these changes
Apr 24, 2023
acywatson
force-pushed
the
disable-flakes
branch
from
276fa5d
to
7157ebd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This experiments with splitting up large test files into smaller ones that can better leverage Playwright's parallel execution. On my M1, this takes execution of the CopyAndPaste suite from ~39s to ~22s, which represents a roughly 43% reduction in test runtime. This uses 5 workers though, and I'm not sure the CI machines on GitHub will provide the same results.
If this works well, we can see if it makes sense to split other suites, or maybe even split down to one-test-per-file (not sure how linearly the execution time savings will scale with test granularity).
Also, we're having consistent CI failures due to flaky tests in Linux/Collab suite. We're tracking a long-term fix in #3915, but until then, this erodes confidence in the CI and burns a ton of compute on retries and re-runs.