Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playground): add support for collapsed margins in draggable block #4823

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

mathieumetral
Copy link
Contributor

Add support for collapsed margins for draggable blocks in the playground.

Before

lexical-drag-margins-before.mov

After

lexical-drag-margins-after.mov

@vercel
Copy link

vercel bot commented Jul 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 3:53pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 3:53pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 25, 2023
Copy link
Collaborator

@ivailop7 ivailop7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a second pair of eyes would be nice.

@fantactuka fantactuka merged commit 43288fc into facebook:main Jul 27, 2023
41 of 43 checks passed
@mathieumetral mathieumetral deleted the f/playground-drag-margins branch July 27, 2023 15:10
@acywatson acywatson mentioned this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants