Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added "Page Break" to Lexical Playground #4842

Merged
merged 8 commits into from
Aug 2, 2023
Merged

Added "Page Break" to Lexical Playground #4842

merged 8 commits into from
Aug 2, 2023

Conversation

Dias1c
Copy link
Contributor

@Dias1c Dias1c commented Jul 28, 2023 •
edited
Loading

image

New Page Break Plugin

Page Break - breaks page. You can see it when you are exporting this document to PDF.
Its helpfull thing if you are working with PDF document.

On exporting created HTML to PDF

image

How to create page break?

  1. Using toolbar (Click to + insert button in toolbar, and select Page Break option)
  2. Using slash / menu (Start writing /page and select Page Break)

Additional information

I have loaded scissors icon from there
image
For icon using CC0 License

@vercel
Copy link

vercel bot commented Jul 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2023 2:34pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2023 2:34pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 28, 2023
@ivailop7
Copy link
Collaborator

Looking great! For the icon, we've been using the bootstrap icons pack, it has a scissors icon as well. Would be nice to keep it consistent.

https://icons.getbootstrap.com/

@Dias1c
Copy link
Contributor Author

Dias1c commented Jul 28, 2023 •
edited
Loading

@ivailop7 Ah, ok. I will change it tomorrow soon as possible :)

acywatson
acywatson approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@acywatson acywatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Dias1c
Copy link
Contributor Author

Dias1c commented Jul 29, 2023

Looking great! For the icon, we've been using the bootstrap icons pack, it has a scissors icon as well. Would be nice to keep it consistent.

https://icons.getbootstrap.com/

I have replaced scissors icon to bootstraps scissors icon

@ivailop7
Copy link
Collaborator

ivailop7 commented Aug 2, 2023

Just formatting left to pass integrity checks and it's ready to go

@ivailop7 ivailop7 merged commit d4b1922 into facebook:main Aug 2, 2023
43 checks passed
@Dias1c Dias1c deleted the ft/plugin/page-break branch August 2, 2023 18:12
@acywatson acywatson mentioned this pull request Aug 9, 2023
Merged
ibastawisi added a commit to ibastawisi/matheditor that referenced this pull request Aug 18, 2023
@ibastawisi
add page break plugin
e3192fd 
source: facebook/lexical#4842
ibastawisi added a commit to ibastawisi/matheditor that referenced this pull request Aug 18, 2023
@ibastawisi
add page break plugin
01c3778 
source: facebook/lexical#4842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acywatson acywatson acywatson approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dias1c @ivailop7 @acywatson @facebook-github-bot