Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make subscript and superscript text formats mutually exclusive #5317

Merged
merged 10 commits into from
Dec 5, 2023

Conversation

geryogam
Copy link
Contributor

@geryogam geryogam commented Dec 1, 2023

Closes #5303

Copy link

vercel bot commented Dec 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 1:37pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 1:37pm

@facebook-github-bot
Copy link
Contributor

Hi @geryogam!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 1, 2023
@geryogam geryogam changed the title Make subscript and superscript formats mutually exclusive Make subscript and superscript text formats mutually exclusive Dec 1, 2023
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! Do you mind adding a unit test?

packages/lexical/src/nodes/LexicalTextNode.ts Outdated Show resolved Hide resolved
@geryogam
Copy link
Contributor Author

geryogam commented Dec 5, 2023

@zurfyx I made the requested changes, could you review again?

@zurfyx
Copy link
Member

zurfyx commented Dec 5, 2023

Thanks for the updates!

@zurfyx zurfyx merged commit 7eb87b4 into facebook:main Dec 5, 2023
40 of 45 checks passed
@geryogam geryogam deleted the patch-1 branch December 6, 2023 09:27
@geryogam
Copy link
Contributor Author

geryogam commented Dec 6, 2023

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: subscript and superscript text formats are not mutually exclusive
3 participants