Fix DecoratorNodes being treated as block elements
#5371
Conversation
9larsons
requested review from
zurfyx,
fantactuka and
acywatson
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
I'm surprised that no tests are breaking, since I made insertNodes considering the decorators (which in fact before were not included as blocks and I had to include them for it to work).
I haven't reviewed insertNodes in detail again, so for my part the only thing I can point out at a glance is a comment about the return type.
There was a problem hiding this comment.
Thanks for looking into this! The terminology for this function is not correct. We have originally referred to blocks as a piece of content that ocuppies the entire horizontal space, resembling display: block on the browser. Decorator nodes can be blocks so I'd be inclined the say that we have to fix this instead https://github.com/facebook/lexical/blob/main/packages/lexical-selection/src/range-selection.ts#L77
Stamping to unblock since it's been about a month since this was open but ideally we want to iterate on this
closes #5369
This is a result of the larger insertNodes changes in v0.12.3+.
Causal code:
https://github.com/facebook/lexical/pull/5002/files#diff-33353db27f56a5d74e7281df0a8a2fc223eef41e9dc2efc723a412560a0148c9R561-R563
INTERNAL_$isBlockis treating (non-inline)DecoratorNodes as block elements, causingElementNodemethods being called on decorator nodes that result in broken functionality.While someone could extend the decorator node class to have the indent and format properties, they are generally not elements and should not be treated as such.