Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical-playground] Fix Table Hover Actions Noclick Bug #6375

Merged
merged 1 commit into from
Jul 8, 2024
Merged

[lexical-playground] Fix Table Hover Actions Noclick Bug #6375

merged 1 commit into from
Jul 8, 2024

Conversation

ivailop7
Copy link
Collaborator

@ivailop7 ivailop7 commented Jul 6, 2024 •
edited
Loading

Had an annoying bug in the Table Hover Actions plugin, where when one hovers over one of the buttons but then clicks the other one, the state was not correct. Fixed.

Before:

Screen.Recording.2024-07-06.at.22.02.34.mov

After:

Screen.Recording.2024-07-06.at.22.02.53.mov

@vercel Vercel
Copy link

vercel bot commented Jul 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2024 9:04pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2024 9:04pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 6, 2024

size-limit report 📦

Path Size
lexical - cjs 28.47 KB (0%)
lexical - esm 28.28 KB (0%)
@lexical/rich-text - cjs 36.86 KB (0%)
@lexical/rich-text - esm 28.08 KB (0%)
@lexical/plain-text - cjs 35.49 KB (-0.04% 🔽)
@lexical/plain-text - esm 25.3 KB (0%)
@lexical/react - cjs 38.82 KB (0%)
@lexical/react - esm 29.27 KB (0%)

potatowagon
potatowagon approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@potatowagon potatowagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ivailop7 ivailop7 added this pull request to the merge queue Jul 8, 2024
Merged via the queue into facebook:main with commit 57e0c19 Jul 8, 2024
41 of 42 checks passed
2wheeh pushed a commit to 2wheeh/lexical that referenced this pull request Jul 17, 2024
@ivailop7 @2wheeh
[lexical-playground] Fix Table Hover Actions Noclick Bug (facebook#6375)
2f2b667 
Co-authored-by: Ivaylo Pavlov <ipavlov@Ivaylos-MacBook-Pro.local>
@phazingazrael phazingazrael mentioned this pull request Aug 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potatowagon potatowagon potatowagon approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivailop7 @potatowagon @facebook-github-bot