Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-playground][lexical-table] Bug Fix: Fix Shift+ Down Arrow regression for table sequence. #6393

Merged

Conversation

serey-roth
Copy link
Contributor

Description

Fixes an issue where Shift + Down Arrow selects only the first table in a table sequence. The fix ensures that the selection extends to include the next table(s) in sequence.

Before

Shift + Down Arrow selects only the first table.

https://www.loom.com/share/05d1f521688f48098dc4aa63eb4060f0?sid=46796142-ba1f-45f8-aef9-ff9a0ec44074

After

Shift + Down Arrow includes the next table in the selection.

https://www.loom.com/share/b01ca74cfb6940e78fc321dbe794a67e?sid=c45fd210-7b36-48d4-b9c5-d13e794a8dbb

Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 4:54pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 4:54pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 11, 2024
@serey-roth serey-roth changed the title [lexical-playground][lexical-table] Bug Fix: Fix shift+down regression for table sequence. [lexical-playground][lexical-table] Bug Fix: Fix Shift+ Down Arrow regression for table sequence. Jul 11, 2024
Copy link

size-limit report 📦

Path Size
lexical - cjs 28.48 KB (0%)
lexical - esm 28.29 KB (0%)
@lexical/rich-text - cjs 36.9 KB (0%)
@lexical/rich-text - esm 28.14 KB (0%)
@lexical/plain-text - cjs 35.49 KB (0%)
@lexical/plain-text - esm 25.34 KB (0%)
@lexical/react - cjs 38.8 KB (0%)
@lexical/react - esm 29.31 KB (0%)

@zurfyx zurfyx added this pull request to the merge queue Jul 11, 2024
Merged via the queue into facebook:main with commit 1ecef21 Jul 11, 2024
17 checks passed
2wheeh pushed a commit to 2wheeh/lexical that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants