[lexical-react][lexical-playground] sync draggable block plugin to www #6397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potatowagon
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7 and
Sahejkm
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
potatowagon
changed the title
size-limit report 📦
|
…9382ad6991cd3917e33e9aca:66:6: ERROR - [JSC_BLOCK_SCOPED_DECL_MULTIPLY_DECLARED_ERROR] Block-scoped variable Rect declared more than once. First occurrence: externs.zip//w3c_css.js:858:9
66| class Rect {
potatowagon
commented
Jul 16, 2024
| @@ -17,7 +17,7 @@ type ContainsPointReturn = { | |||
| }; | |||
| }; | |||
|
|
|||
| export class Rect { | |||
| export class Rectangle { | |||
There was a problem hiding this comment.
rename because w3c bundle has a Rect class already and clash in naming cause compiling the prod build to fail
zurfyx
previously approved these changes
Jul 16, 2024
| } | ||
|
|
||
| export default function DraggableBlockPlugin({ | ||
| export default function PlaygroundDraggableBlockPlugin({ |
There was a problem hiding this comment.
Suggested change
| export default function PlaygroundDraggableBlockPlugin({ | |
| export default function DraggableBlockPlugin({ |
There was a problem hiding this comment.
cant rename that to DraggableBlockPlugin as thats the name of the base plugin
ok added |
Sahejkm
approved these changes
Jul 17, 2024
|
failure from flaky test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
abstract out the ui components from draggable block plugin so we can customise the ui for menu and target line
currently sticking with original implementation which depends on the ui component to be a html element to be compatible with ref. will explore (in another PR) if its possible to make this more flexible so we can pass in any react component without having to maintain the ref
Closes #
Test plan
Before
Draggable block plugin works
After
Screen.Recording.2024-07-16.at.6.17.17.PM.mov
no regressions, draggable block plugin still works