Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: fix build failure on astro integration tests #6414

Merged
merged 1 commit into from
Jul 18, 2024
Merged

CI: fix build failure on astro integration tests #6414

merged 1 commit into from
Jul 18, 2024

Conversation

2wheeh
Copy link
Contributor

@2wheeh 2wheeh commented Jul 18, 2024 •
edited
Loading

Description

This updates node version to the latest LTS 20.15.1 on integrations tests workflow due to the regression in the latest astro 4.11.6.

Should other tests be updated as well now?

Closes #6413

Test plan

run integrations tests

@vercel Vercel
Copy link

vercel bot commented Jul 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 7:48am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 7:48am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2024
@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size
lexical - cjs 28.75 KB (0%)
lexical - esm 28.61 KB (0%)
@lexical/rich-text - cjs 37.2 KB (0%)
@lexical/rich-text - esm 28.13 KB (0%)
@lexical/plain-text - cjs 35.81 KB (0%)
@lexical/plain-text - esm 25.48 KB (0%)
@lexical/react - cjs 39.05 KB (0%)
@lexical/react - esm 29.48 KB (0%)

@ivailop7 ivailop7 added this pull request to the merge queue Jul 18, 2024
Merged via the queue into facebook:main with commit 85abcde Jul 18, 2024
41 of 45 checks passed
@2wheeh 2wheeh deleted the bump-node branch July 18, 2024 08:35
@phazingazrael phazingazrael mentioned this pull request Aug 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivailop7 ivailop7 ivailop7 approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: build failure on astro integration test due to node version
3 participants
@2wheeh @ivailop7 @facebook-github-bot