Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-playground] Bug Fix: Fix table row/column index when resizing merged cells #6630

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

patrick-atticus
Copy link
Contributor

Description

When table cells are merged (either vertically or horizontally) and you try to resize them, it resizes the row or column of the top/left cell.

Update the index to account for colspan and rowspan so the correct column/row is resized.

Closes #6623

Test plan

Before

Screen.Recording.2024-09-13.at.9.44.16.AM.mp4

After

Screen.Recording.2024-09-13.at.9.38.20.AM.mp4

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 1:06am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 1:06am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2024
Copy link

github-actions bot commented Sep 12, 2024

size-limit report 📦

Path Size
lexical - cjs 29.77 KB (0%)
lexical - esm 29.6 KB (0%)
@lexical/rich-text - cjs 38.24 KB (0%)
@lexical/rich-text - esm 31.46 KB (0%)
@lexical/plain-text - cjs 36.82 KB (0%)
@lexical/plain-text - esm 28.86 KB (0%)
@lexical/react - cjs 40.01 KB (0%)
@lexical/react - esm 32.93 KB (0%)

Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work much better this way!

@etrepum etrepum added this pull request to the merge queue Sep 13, 2024
Merged via the queue into facebook:main with commit c0f1e20 Sep 13, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: table resizes wrong column when cell is merged
3 participants