-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical-table] Bug Fix: Fix crash in $deleteCellHandler #6650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Sep 19, 2024
size-limit report 📦
|
etrepum
force-pushed
the
deleteCellHandler-fix
branch
from
September 19, 2024 23:34
7391dde
to
9b2ba70
Compare
etrepum
changed the title
[lexical-table] Bug Fix: Fix crash in $deleteCellHandler
[lexical-table][lexical-code] Bug Fix: Fix crash in $deleteCellHandler
Sep 19, 2024
etrepum
changed the title
[lexical-table][lexical-code] Bug Fix: Fix crash in $deleteCellHandler
[lexical-table] Bug Fix: Fix crash in $deleteCellHandler
Sep 19, 2024
etrepum
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
September 20, 2024 00:07
etrepum
force-pushed
the
deleteCellHandler-fix
branch
from
September 20, 2024 00:25
cb9da85
to
2bf1145
Compare
etrepum
force-pushed
the
deleteCellHandler-fix
branch
from
September 20, 2024 00:36
2bf1145
to
8d4c7e6
Compare
potatowagon
approved these changes
Sep 20, 2024
Thank you for your help on this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
extended-tests
Run extended e2e tests on a PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In certain situations
$deleteCellHandler
will remove a table without fixing up the selection and also return false, which turns into a crash in the editor's command listener because the selection's anchor or focus is no longer connected to the root.Closes #6581
Test plan
Before
After
No crash