Use the injected treeProps for Layout PerfEvent #574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boduan-coder
changed the title
|
Hi @colriot , can you please help review this change again? I somehow mess up the old branch and have to create this new pull request to address your comment. Could you please help review when getting a chance? Appreciate it. |
There was a problem hiding this comment.
@colriot has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
colriot
suggested changes
Aug 1, 2019
litho-core/src/main/java/com/facebook/litho/LogTreePopulator.java
Outdated
Show resolved
Hide resolved
litho-core/src/main/java/com/facebook/litho/LogTreePopulator.java
Outdated
Show resolved
Hide resolved
|
@boduan402 has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@colriot has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the runtime, the ComponentContext's treeProps could be null. In this case, it would better to use the treeProps that provided by caller.