Add explicit dependency on @babel/runtime to metro-runtime
#816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Previously, `babel/runtime` was a transitive dependency of RN projects via `metro-react-native-babel-preset` -> `babel/plugin-transform-regenerator`. `babel/runtime` is a dependency of injected babel helpers, so we need it to be a transitive dependency of an RN project under `react-native`. Removing the previous implicit dependency broke RN builds, this adds the dependency to `metro-runtime` to make it explicit. I've created a 0.70.x branch for Metro from 0.70.2 and will cherry pick this up as a hotfix 0.70.3 release. Reviewed By: motiz88 Differential Revision: D36165366 fbshipit-source-id: d7e13cf337acb88e9d9733f8caf332aa4303ab97
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D36165366 |
robhogan
added a commit
that referenced
this pull request
May 5, 2022
Hotfix adding (#816) to the 0.70.x branch
|
Not sure why the bot didn't pick this up, but this landed in 0e4cb75 |
|
Would it make sense to specify a more recent version here and include it in the default value of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously,
babel/runtimewas a transitive dependency of RN projects viametro-react-native-babel-preset->babel/plugin-transform-regenerator.babel/runtimeis a dependency of injected babel helpers, so we need it to be a transitive dependency of an RN project underreact-native.Removing the previous implicit dependency broke RN builds, this adds the dependency to
metro-runtimeto make it explicit.I've created a 0.70.x branch for Metro from 0.70.2 and will cherry pick this up as a hotfix 0.70.3 release.
Reviewed By: motiz88
Differential Revision: D36165366