Fusion QuicFizzFactory into FizzCryptoFactory #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
@mjoras has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
deadalnix
force-pushed
the
fizzfactorymerge
branch
from
a727141
to
24b9bc5
Compare
There was a problem hiding this comment.
@yangchi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
deadalnix
force-pushed
the
fizzfactorymerge
branch
from
24b9bc5
to
6f3e3b5
Compare
There was a problem hiding this comment.
@yangchi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
deadalnix
force-pushed
the
fizzfactorymerge
branch
from
6f3e3b5
to
e73462f
Compare
There was a problem hiding this comment.
@yangchi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are strongly coupled, which indicate this is probably better to do it as one class.