Skip to content
This repository has been archived by the owner on Oct 15, 2019. It is now read-only.

Upgrade to Netty 4 #50

Closed
infynyxx opened this issue Mar 27, 2013 · 21 comments
Closed

Upgrade to Netty 4 #50

infynyxx opened this issue Mar 27, 2013 · 21 comments

Comments

@infynyxx
Copy link
Contributor

Netty 4 is nearing completion so, it would be lovely to see that up for use.

@andrewcox
Copy link
Contributor

Is already being worked on

@infynyxx
Copy link
Contributor Author

Sweet. Can't find that branch though.

@andrewcox
Copy link
Contributor

Sorry I should have been more specific. There is no branch for it yet, but it's almost ready to go up. Just working out a few performance problems.

@andrewcox andrewcox reopened this Mar 27, 2013
@ghost ghost assigned andrewcox Mar 27, 2013
@hgschmie
Copy link
Contributor

Most users of nifty / swift are still on netty 3.x. Unless we can ensure that netty 3 and netty 4 can co-exist, we need to publish two separate artifacts. I can a factoring out of a reasonable nifty API and then offer a n3 and n4 implementation but an unconditional switch would probably require shading in the netty dependency.

@infynyxx
Copy link
Contributor Author

Agreed.

@dain
Copy link
Contributor

dain commented Mar 27, 2013

Netty 3 and 4 are in different packages (io.netty and org.jboss.netty) , so there should be no problem running them in the same VM.

@andrewcox
Copy link
Contributor

https://github.com/andrewcox/nifty/tree/netty4
https://github.com/andrewcox/swift/tree/netty4

These branches build and pass all tests running on netty 4, will be cleaning up and make pull requests soon after netty 4 final is released.

@vongosling
Copy link

notice pom netty dependency version is 4.0.0.CR1 ,have you test netty latest version,such as netty-4.0.12 final?

@fuyou001
Copy link

fuyou001 commented Jun 7, 2014

have Upgraded to Netty4 ?

@raultang
Copy link

raultang commented Aug 9, 2014

https://github.com/andrewcox/nifty/tree/netty4
this branch is not using the stable version of netty 4 which is quite different and will lead the "java.lang.OutOfMemoryError: Java heap space" error.

@raultang
Copy link

raultang commented Aug 9, 2014

@andrewcox are you still working on this ?
Seems there is no replacement solutions for using thrift on netty4 or netty5.

@yc2prime
Copy link

Still no plan for netty 4 yet?

@andrewcox
Copy link
Contributor

I am working on this again. Here is my working branch that builds & verifies but needs lots of addressing todo items and some code cleanup.

https://github.com/andrewcox/nifty/tree/netty4.0.24

@andrewcox
Copy link
Contributor

And also needs to be rebased to current changes

@sangupta
Copy link

Any updates on finalizing the Netty 4 branch soon?

@dmk23
Copy link

dmk23 commented May 28, 2015

Anyone working on 4.1 ?

@ghost
Copy link

ghost commented Aug 5, 2015

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

@jagadeeshmohan
Copy link

Any updates on this?

@PaniniGelato
Copy link

any updates?

@jagadeeshmohan
Copy link

any updates on this?

1 similar comment
@wxpjimmy
Copy link

any updates on this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests