-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breeze kvstore topology does not work #13
Comments
Can you install Reason for this error message is that we don't want to enforce matplotlib to be a hard dependency of breeze tool (as it is very big library). Hence we made it soft dependency You don't need to rebuild anything. Just install matplotlib and run command again. I will change message to be more specific. Let me know if it works for you. |
sudo apt-get install python-matplotlib |
commit e4d9ff3#diff-304d33f4448afe5d095ce2e660da325b add better error description of how to fix it. Closing the task. |
Thanks, I understood the reason why matplotlib was not installed. The better error description sounds good.
And I try the command after
I imagine that a reason of the issue is that my enviroment is only CUI (not GUI)... |
) Summary: Take the README.md from https://github.com/facebookexperimental/mononoke/blob/7ead0e29e41aec0771531a4650b6170bc1ff6566/README.md and apply it on Eden repo. Re-add the Cargo.toml file that declares Cargo workspace. Re-add fbcode_builder/getdeps manifest for Mononoke Pull Request resolved: facebook/sapling#13 Test Plan: ./build/fbcode_builder/getdeps.py build mononoke ./build/fbcode_builder/getdeps.py test mononoke Reviewed By: ahornby Differential Revision: D19833059 Pulled By: lukaspiatkowski fbshipit-source-id: fb37e13306c0b9969a7c4e52b05e1a66a577022f
Summary: There is a race condition when KvStoreWrapper and ZMQ background threads are destroyed. This diff is an attempt to explicitly destroy KvStoreWrapper in TearDown Also use unique_ptr instead of shared_ptr ``` WARNING: ThreadSanitizer: data race (pid=49594) Write of size 8 at 0x7ba000000220 by thread T1: #0 close <null> (link_monitor_test+0xdb1f6a) #1 zmq::signaler_t::~signaler_t() /home/engshare/third-party2/zeromq/4.3.1/src/zeromq-4.3.1/src/signaler.cpp:114:20 (link_monitor_test+0xbd1274) Previous read of size 8 at 0x7ba000000220 by main thread: #0 epoll_ctl <null> (link_monitor_test+0xd9bdef) #1 epoll_del /home/engshare/third-party2/libevent/1.4.14b_hphp/src/libevent-1.4.14b-stable/epoll.c:485 (link_monitor_test+0xec4253) #2 folly::EventBaseEvent::eb_event_del() <null> (link_monitor_test+0xa747ef) #3 folly::EventHandler::~EventHandler() <null> (link_monitor_test+0xa74a70) #4 std::_Hashtable<int, std::pair<int const, openr::OpenrEventBase::ZmqEventHandler>, std::allocator<std::pair<int const, openr::OpenrEventBase::ZmqEventHandler> >, std::__detail::_Select1st, std::equal_to<int>, std::hash<int>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::~_Hashtable() <null> (link_monitor_test+0x219620) #5 openr::OpenrEventBase::~OpenrEventBase() <null> (link_monitor_test+0x212d8d) #6 openr::KvStore::~KvStore() <null> (link_monitor_test+0x1bfbb7) #7 openr::KvStore::~KvStore() <null> (link_monitor_test+0x1bfbe9) #8 openr::KvStoreWrapper::~KvStoreWrapper() <null> (link_monitor_test+0x117533) #9 std::_Sp_counted_ptr_inplace<openr::KvStoreWrapper, std::allocator<openr::KvStoreWrapper>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() <null> (link_monitor_test+0x116fbd) #10 LinkMonitorTestFixture::~LinkMonitorTestFixture() <null> (link_monitor_test+0xf8285) #11 LinkMonitorTestFixture_BasicOperation_Test::~LinkMonitorTestFixture_BasicOperation_Test() <null> (link_monitor_test+0xf7ee9) #12 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) <null> (link_monitor_test+0xc4b2ae) #13 __libc_start_main /home/engshare/third-party2/glibc/2.26/src/glibc-2.26/csu/libc-start.c:308:16 (libc.so.6+0x211a5) ``` Reviewed By: yi-xian Differential Revision: D20148667 fbshipit-source-id: 71634c08df8ebbc98a6b8c4aa3329166834453f2
Issue Description
The
breeze kvstore topology
does not work becausematplotlib
was not installed atbuild_openr.sh
script.Environment
Minimal test code / Steps to reproduce the issue
build_openr.sh
.What's the actual result?
What's the expected result?
The command generates png file to
/tmp/
solution I guess
kvstore.py
inopenr/py/openr/cli/commands
:pip install matplotlib
build_openr.sh
The text was updated successfully, but these errors were encountered: