Add sudo to build script #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Open/R is normally built with the entire build script executed under the root account directly or via sudo. Adding sudo allows for the Open/R build script to use root privileges as needed.
|
Thanks @sonoble for the pull request with proper summary and test-plan. I will initiate a pull. This request will be automatically closed when pull is successful. |
There was a problem hiding this comment.
@saifhhasan is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The Open/R build script is designed to be executed under the root account directly or via sudo.
Adding sudo within the script allows for the Open/R build script to use root privileges as needed.
Test Plan: