Skip to content

Conversation

JorisVanEijden
Copy link
Contributor

Both JsonWireProtocol and w3c protocol say to leave an entry off
rather than having a null value.

https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol
https://w3c.github.io/webdriver/#add-cookie

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@JorisVanEijden
Copy link
Contributor Author

The travis fail seems to be unrelated to this PR:

1) Facebook\WebDriver\WebDriverTimeoutsTest::testShouldFailGettingDelayedElementWithoutWait
Failed asserting that exception of type "Facebook\WebDriver\Exception\NoSuchElementException" is 
thrown.

How does this happen? And what can I do to fix it?

The code coverage decreased even though every single line I touched is tested and I added an extra test. How does this happen? And what can I do to fix it?

@derekmd
Copy link

derekmd commented May 2, 2019

With Chromedriver 74 binaries released, it now causes some cookie requests to fail without this pull request being merged and tagged.

https://chromium-review.googlesource.com/c/chromium/src/+/1366925/3/chrome/test/chromedriver/window_commands.cc#1564

As a workaround, you must manually set every cookie value to avoid null Set-Cookie items being sent.

@OndraM OndraM force-pushed the 626-no-null-values-in-cookie branch from 9c40072 to 3a96b36 Compare June 9, 2019 13:02
@OndraM
Copy link
Collaborator

OndraM commented Jun 9, 2019

Thanks @JorisVanEijden for the catch. I rebased the branch against current community branch, let's see if the Travis build now pass. If so, I will get it merged.

@OndraM OndraM merged commit 550edf5 into php-webdriver:community Jun 9, 2019
@OndraM
Copy link
Collaborator

OndraM commented Jun 9, 2019

Merged, thanks @JorisVanEijden! 💯

@OndraM OndraM changed the title 626 no null values in cookie Do not send null values in cookie Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants