This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
Adding support for autolayout constraint multipliers #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the multiplier property of NSLayoutConstraint is read-only, we recreate the constraint with all existing attributes besides the desired multiplier.
…ntMultiplier property names.
|
Getting a Travis CI build error related to |
| ^(NSLayoutConstraint *obj, const CGFloat values[]) { | ||
| // The multiplier property is read-only so recreate the constraint with all existing attributes | ||
| // besides the desired multiplier. | ||
| obj = [NSLayoutConstraint constraintWithItem:obj.firstItem |
There was a problem hiding this comment.
Hm, I'm not sure if this will work. Wouldn't you need to also update / replace the constraint on the view it's attached to?
|
Having trouble updating / replacing the constraint in the view it's attached to. Closing this for now. |
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've accommodated the readonly multiplier property the best way I could think of here. Also added the constraint constant property to the unit tests as it was missing.