This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Make some builtin functions aware of abstract strings. #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanventer
force-pushed
the
absstring
branch
from
31e6f81
to
86063c0
Compare
cblappert
approved these changes
Oct 28, 2017
There was a problem hiding this comment.
@hermanventer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
NTillmann
reviewed
Oct 31, 2017
| export function ToStringValue(realm: Realm, val: Value): Value { | ||
| if (val.getType() === StringValue) return val; | ||
| let str; | ||
| if (typeof val === "string") { |
leobalter
pushed a commit
to bocoup/prepack
that referenced
this pull request
Oct 31, 2017
Summary: Builtin functions that are side-effect free can trivially be modified to return abstract values if one or more of their arguments are abstract. This pull request provides such behavior for the Error constructor, Error.prototype.toString and String.prototype.split and slice. Closes facebookarchive#1110 Differential Revision: D6182526 Pulled By: hermanventer fbshipit-source-id: d95c8045ff75c35f1b55dc668c080aa394ccb43d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builtin functions that are side-effect free can trivially be modified to return abstract values if one or more of their arguments are abstract.
This pull request provides such behavior for the Error constructor, Error.prototype.toString and String.prototype.split and slice.