Strips Flow types if React is enabled #1119
Conversation
|
|
||
| // taken directly from Babel: | ||
| // https://github.com/babel/babel/blob/master/packages/babel-plugin-transform-flow-strip-types/src/index.js | ||
| export function stripFlowTypeAnnotations(ast: BabelNode): void { |
There was a problem hiding this comment.
This is all taken from Babel
There was a problem hiding this comment.
Can we just use the code from the upstream package rather than copy then?
There was a problem hiding this comment.
If we can't use the code as is by reference, we should document the exact differences but we also need to include copyright header (which is McKenzie I guess).
There was a problem hiding this comment.
We can't use it from upstream but I'll make make those changes in another PR.
|
@yinghuitan They don't break the compiler, they just result in invalid output after which Babel can't parse. |
There was a problem hiding this comment.
@trueadm is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
I see you already landed, but I'd like to request a follow up. :) |
Release note: none
With the
reactEnabledoption turned on, Flow now get parsed by Babylon, which can break the output. So this PR traverses the AST after serialization and strips all Flow types using the same method from the core Babel strip Flow types plugin to ensure the Flow types aren't in the final output.