This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Error if an abstract function that might throw is called within a try #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
force-pushed
the
warnforcatchinpure
branch
from
b90e8e6
to
dde7e50
Compare
…a try This is a follow up to facebookarchive#1142. If we call an unknown function it might throw which will take a different control Flow. facebookarchive#1264 is the follow up to do this properly but since we don't have a use case right now, we can just issue a recoverable error if this happens.
sebmarkbage
force-pushed
the
warnforcatchinpure
branch
from
dde7e50
to
aadf322
Compare
There was a problem hiding this comment.
@sebmarkbage is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #1142. If we call an unknown function it might throw which will take a different control flow. #1264 is the follow up to do this properly but since we don't have a use case right now, we can just issue a recoverable error if this happens.