Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Update webpack and change Babel settings #1532

Closed
wants to merge 3 commits into from

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Mar 5, 2018

Release notes: Prepack now ships Node 6.1+ compatible source

This PR does four things:

  • updates webpack to v4
  • changes our Babel presets so we now transpile far less code, in fact we now target node 6.1+ min (as we already specified in package.json). The bundle created for the REPL still targets ES5.
  • updated eslint
  • updated circleci node version to 9.7.1 (yarn says it doesn't support it, but there appears to be no issues)

This should improve runtime performance and make debugging easier. In fact, there's no real need for sourcemaps now, as the code looks almost identical minus module references.

Performance comparisons:

Before:
screen shot 2018-03-04 at 8 34 10 pm
After:
screen shot 2018-03-04 at 8 34 22 pm

Before:
screen shot 2018-03-04 at 8 35 07 pm
After:
screen shot 2018-03-04 at 8 35 13 pm

Before:
screen shot 2018-03-04 at 8 43 23 pm
After:
screen shot 2018-03-04 at 8 43 16 pm

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trueadm has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants