This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Rename __registerAdditionalFunction -> __optimize #1561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cblappert
approved these changes
Mar 9, 2018
There was a problem hiding this comment.
@trueadm is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 10, 2018
Summary: Release notes: none When we evaluate multiple additional functions, they might remove other additional functions that were defined as additional functions. This causes a serializer issue. If we check if they have info from the visitor we can avoid hitting an invariant. This fixes one of the issues flagged in #1550, thus pulling in the test that was failing from the PR. This PR is rebased on #1561 Closes #1555 Differential Revision: D7220598 Pulled By: trueadm fbshipit-source-id: 2d0b87e23ecd93b325f44daa3a7c21ff3591d733
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes:
__registerAdditionalFunctionis now__optimizeThis PR renames
__registerAdditionalFunctionto__optimizeand removes all tests that use the// additional functionslogic in favor of declaratively using__optimize. Also the serializer option foradditionalFunctionsis removed too.