This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
debug-fb-www changes #1629
Closed
debug-fb-www changes #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Mar 21, 2018
scripts/debug-fb-www.js
Outdated
| @@ -57,6 +57,10 @@ let prepackOptions = { | |||
| } | |||
| errorsCaptured.push(diag); | |||
| if (diag.severity !== "Warning") { | |||
| if (diag.errorCode === "PP0025") { | |||
| // recover from `unable to evaluate "key" and "ref" on a ReactElement due to an abstract config passed to createElement`, | |||
gaearon
approved these changes
Mar 21, 2018
There was a problem hiding this comment.
@trueadm is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: none
For debug-fb-ww we can recover from key and ref issues on ReactElements so we can evaluate more.