This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Support basic arrow function serialization #1650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueadm
changed the title
trueadm
added
the
WIP
NTillmann
reviewed
Mar 26, 2018
| ArrowFunctionExpression: { | ||
| enter(path: BabelTraversePath, state: ClosureRefVisitorState) { | ||
| state.functionInfo.depth++; | ||
| state.functionInfo.lexicalDepth++; |
trueadm
removed
the
WIP
trueadm
changed the title
|
Rebased and added some basic tests. @NTillmann would be good to review this now as it's a long standing PR that was actually relatively simple to implement for basic cases. |
trueadm
changed the title
There was a problem hiding this comment.
@trueadm is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: adds basic ES2015 arrow function serialization
This allows Prepack to serialize back to arrow functions and also traverse them correctly when understanding
this.