Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Rename prepack > prepack-cli so we don't run cli on yarn pack #1668

Closed
wants to merge 2 commits into from

Conversation

cblappert
Copy link
Contributor

@cblappert cblappert commented Mar 27, 2018

Release Notes: None

prepack command renamed to prepack-cli

@NTillmann
Copy link
Contributor

Various places (including our GitHub landing page) mentions yarn prepack is the way to go. Do we really have to rename it? Why couldn't yarn prepack stay the main thing?

@cblappert
Copy link
Contributor Author

cblappert commented Mar 27, 2018

Yarn and npm reserve "prepack" in package.json as a keyword that activates at certain times (specifically when you run yarn pack before it creates the tgz archive). Keeping the prepack command means that the cli will be run every time you run yarn pack.

Edit: this is also the case for npm pack (and depending on the version npm publish)

@hermanventer
Copy link
Contributor

Please provide a description.

Copy link
Contributor

@hermanventer hermanventer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the landing page and any internal references to "yarn prepack".

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cblappert is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cblappert is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@hermanventer hermanventer deleted the fix_pkgjson branch March 30, 2018 20:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants